Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>: >>>>> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { >>>> >>>> Rather than scatter fragile magic numbers, like 10, throughout the >>>> code, if you're hell-bent on checking for printf errors you could >>>> write a little wrapper function that hid the magic number and bundled >>>> up the errno stuff. >>> >>> >>> BTW, how the magic number "10" was calculated? >> >> Does the passed format string indicate how many characters should be >> printed at least? > > So, the check is a bit compromised. > The printf() should print at lease 10 characters. > If "target" or "cmdline" is not NULL, it should print more. printf() / fprintf() return a negative value if an error such as ENOSPC occurs. So just check for < 0 and preferably use a wrapper. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html