On Thu, Oct 20, 2016 at 09:37:30AM +0200, Geert Uytterhoeven wrote: > On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxx> wrote: > > I'm not in favour of this. > > > > +extern void mmioset(void *, unsigned int, size_t); > > +extern void mmiocpy(void *, const void *, size_t); > > + > > #ifndef __ARMBE__ > > static inline void memset_io(volatile void __iomem *dst, unsigned c, > > size_t count) > > { > > - extern void mmioset(void *, unsigned int, size_t); > > mmioset((void __force *)dst, c, count); > > } > > > > The reason they're declared _within_ memset_io() is to prevent people > > from using them by hiding their declaration. Moving them outside is > > an open invitation to stupid people starting to use them as an "oh it > > must be an official API". > > If they're not intended for public use, they should (also) be prefixed > with "__" or even "____" to make this clear. Tried that with the __cpuc_* cache flushing interfaces. It doesn't have any effect what so ever. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html