Jim Davis <jim.epost@xxxxxxxxx> writes:
> On Tue, Aug 16, 2016 at 6:35 AM, Dmitry Monakhov <dmonakhov@xxxxxxxxxx> wrote:
>> If build configured w/o modules script fails because lib/ is not exit.
>
> "does not exist"?
>
> When I ran into this once before, it did seem the tar archive was
> fine. But it was disconcerting to see an error message, followed by
> buildtar claiming that the tarball was successfully created...
>
>
>> + tar cf - -C "$tmpdir" . $opts | ${compress} > "${tarball}${file_ext}"
>
> If, somehow, there are files in $tmpdir that aren't in /boot (or /lib)
> then this would put things in the tar archive that weren't there
> before the patch. I don't offhand see how that could happen, but a
> more conservative approach would be to test for /lib.
$tmpdir dir was created by this script. So any files which in $tmpdir are
definitely created with the purpose, and imho it it is reasonable to place
it to tarball. But in order to be on a safe side let's preserve original
behavior. I'll resend the patch.
>
> --
> Jim
Attachment:
signature.asc
Description: PGP signature
