On 2016/04/28 02:20PM, Jesper Dangaard Brouer wrote: > It is practical to be-able-to redefine the location of the LLVM > command 'llc', because not all distros have a LLVM version with bpf > target support. Thus, it is sometimes required to compile LLVM from > source, and sometimes it is not desired to overwrite the distros > default LLVM version. > > This feature was removed with 128d1514be35 ("samples/bpf: Use llc in > PATH, rather than a hardcoded value"). > > Add this features back. Note that it is possible to redefine the LLC > on the make command like: > > make samples/bpf/ LLC=~/git/llvm/build/bin/llc I don't have an objection to this patch, but you didn't explain why/how this approach is better than just doing: PATH=~/git/llvm/build/bin make samples/bpf/ - Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html