On 2016-03-25 10:03, Geert Uytterhoeven wrote: > On Fri, Mar 25, 2016 at 9:54 AM, Geert Uytterhoeven >>> Al Viro (1): >>> unbreak allmodconfig KCONFIG_ALLCONFIG=... >> >> I can now indeed drop the >> >> CONFIG_MODULES=y >> >> line from my >> >> allmod.config >> >> However, this fix has the side-effect of enabling CONFIG_MODULES silently for >> >> make allyesconfig KCONFIG_ALLCONFIG=1 >> >> Adding an explicit >> >> CONFIG_MODULES=n >> >> to the allyes.config file fixes that. >> >> IMHO CONFIG_MODULES should default to y when using allmodconfig, and >> default to n when using allyesconfig. > > Hmm, it seems plain "make allyesconfig" also enables CONFIG_MODULES, and > makes many options modular. Is that intentional, especially the latter? allyesconfig builds everything into the kernel, so why exclude the module loader. And there are a few modules with a 'depends on m' statement, either because this is test code in samples/ which is not even considered when linking the kernel, or there is some "issue" when the code is built-in. The statement might also be completely bogus, but that's not a job of allyesconfig to decide. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
