On Thu, Jan 28, 2016 at 11:14:35AM +0800, Fengguang Wu wrote: > On Wed, Jan 27, 2016 at 10:44:01AM +0100, Arnd Bergmann wrote: > > - CONFIG_PHYS_OFFSET needs to be entered manually to be a number > > in 'make config' > > That's a problem for auto tests. I'm really against the idea of providing some kind of "default" to it. Not providing a default means that people _have_ to do some research for their particular system in order to provide a value, and they're more likely to get the right value. Providing a default will lead to the assumption that the value is okay, and then we'll end up with people complaining that their kernel doesn't boot, and is totally silent. The only default I'd accept is one based on the rest of the config - in other words, re-introducing all the physical address of RAM that we used to have in the mach/memory.h files... There's other ways around these kinds of things, the Kconfig system does allow a Kconfig fragment which can be used to pre-set some configuration options to particular values - and so which can be used to set CONFIG_PHYS_OFFSET prior to an allrandconfig or similar. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
