On 01/13/16 12:45, Arnd Bergmann wrote: > On Wednesday 13 January 2016 12:39:18 Andrew Morton wrote: >> >> Randy's "logfs: fix logfs build errors and dependencies" is an >> only-in-mm thing. So it would make sense to combine the two patches >> into a single one and to give that an appropriate changelog. >> >> How does this look? (Primary author was chosen randomly) >> >> >> From: Arnd Bergmann <arnd@xxxxxxxx> >> Subject: logfs: fix logfs build errors and dependencies >> >> Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m: >> >> fs/built-in.o: In function `logfs_mount': >> super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd' >> fs/built-in.o: In function `logfs_get_sb_bdev': >> (.text+0x93530): undefined reference to `logfs_get_sb_mtd' >> >> This patch avoids the error by changing the dependencies of >> logfs in a way that we can no longer configure logfs as built-in >> when the MTD core is a loadable module, while leaving the >> dependency to require at least one of MTD or BLOCK to be >> enabled. >> >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Cc: Michal Marek <mmarek@xxxxxxx> >> Cc: Peter Chen <peter.chen@xxxxxxxxxxxxx> >> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Cc: Joern Engel <joern@xxxxxxxxx> >> Cc: Prasad Joshi <prasadjoshi.linux@xxxxxxxxx> >> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> > > Looks good, thanks! > > Arnd > Thanks also. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html