Dne 14.9.2015 v 21:05 Petr Vorel napsal(a):
> From: Paul Bolle <pebolle@xxxxxxxxxx>
>
> rev_dep expressions can get rather unwieldy, especially if a symbol is
> selected by more than a handful of other symbols. Ie, it's possible to
> have near endless expressions like:
> A && B && !C || D || F && (G || H) || [...]
>
> Chop these expressions into actually readable chunks:
> - A && B && !C
> - D
> - F && (G || H)
> - [...]
>
> Ie, transform the top level "||" tokens into newlines and prepend each
> line with a minus. This makes the "Selected by:" blurb much easier to
> read.
> ---
> Today I found myself wondering why a certain Kconfig was selected.
> Currently menuconfig's help is of no use in complicated cases. Please
> look at the help of USB or CRYPTO to see what I mean.
>
> This is a _hack_ to show what might be a better way to do this. It
> parses a stringified version of the reverse dependency, and not the
> actual reverse dependecy expression. But that was easier to cobble
> together.
>
> One cool improvement would be to change to minus in front of the
> subexpressions to Y or M for those that actually set the symbol. Anyhow,
> other suggestions and feedback is welcome.
>
> Not-yet-signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> Tested-by: Petr Vorel <petr.vorel@xxxxxxxxx>
> Cc: Paul Bolle <pebolle@xxxxxxxxxx>
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Petr Vorel <petr.vorel@xxxxxxxxx>
> ---
> scripts/kconfig/menu.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 81 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index b05cc3d..a8b37a2 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -613,6 +613,86 @@ static struct property *get_symbol_prop(struct symbol *sym)
> }
>
> /*
> + * Assuming we're just past an opening parenthesis in a NUL terminated string,
> + * find it's closing parenthesis and return its postion. Die otherwise.
> + */
> +static const char *matching_paren(const char *s)
> +{
> + int lvl = 1;
> +
> + while (1) {
> + if (*s == '(')
> + lvl++;
> + else if (*s == ')')
> + lvl--;
> + if (lvl == 0)
> + break;
> + if (*s == '\0')
> + /* huh? */
> + exit(1);
assert/abort?
BTW, the whole splitting can be done in a singe loop a-la
while (c = s++) {
if (c == '(')
lvl++;
else if (c == ')')
lvl--;
else if (c == '|' && lvl == 0)
/* insert newline and indent */
/* output c */
}
No need to seek back and forth in the string.
> - expr_gstr_print(sym->rev_dep.expr, r);
> - str_append(r, "\n");
> + rev_dep_gstr_print(sym->rev_dep.expr, r);
... and a cleaner fix would be to patch the printer, instead of
generating a string representation and converting it.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
