Re: PING: [PATCH] make build tool dependencies portable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2015-09-04 22:32 GMT+09:00 Pavel Fedin <p.fedin@xxxxxxxxxxx>:
> Ping
>
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>
>
>> -----Original Message-----
>> From: linux-kbuild-owner@xxxxxxxxxxxxxxx [mailto:linux-kbuild-owner@xxxxxxxxxxxxxxx] On
>> Behalf Of Pavel Fedin
>> Sent: Thursday, August 27, 2015 12:08 PM
>> To: linux-kbuild@xxxxxxxxxxxxxxx
>> Cc: Michal Marek
>> Subject: [PATCH] make build tool dependencies portable
>>
>> Autogenerated .c files depend on their generator tool, and an implicit
>> rule is used to build the tool itself. However, an explicit rule
>> is required on platforms where the .exe suffix is used for hostprogs.
>>
>> This fixes the following errors when building on Cygwin:
>>
>> make[3]: *** No rule to make target 'drivers/video/logo/logo_linux_clut224.c',
>> needed by 'drivers/video/logo/logo_linux_clut224.o'.  Stop.
>> scripts/Makefile.build:403: recipe for target 'drivers/video/logo' failed
>>
>> make[2]: *** No rule to make target 'crypto/asymmetric_keys/x509-asn1.c',
>> needed by 'crypto/asymmetric_keys/x509-asn1.o'.  Stop.
>> scripts/Makefile.build:403: recipe for target 'crypto/asymmetric_keys' failed
>>
>> Signed-off-by: Pavel Fedin <p.fedin@xxxxxxxxxxx>
>> ---
>>  drivers/video/logo/Makefile | 1 +
>>  scripts/Makefile.build      | 2 ++
>>  2 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
>> index 3b43781..cc636f1 100644
>> --- a/drivers/video/logo/Makefile
>> +++ b/drivers/video/logo/Makefile
>> @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
>>  extra-y += $(call logo-cfiles,_gray256,pgm)
>>
>>  pnmtologo := scripts/pnmtologo
>> +$(pnmtologo): $(objtree)/scripts/pnmtologo.c


scripts/Makefile has the following:

hostprogs-$(CONFIG_LOGO)         += pnmtologo


This should work if you enable CONFIG_LOGO in Kconfig.





>>  # Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..."
>>  quiet_cmd_logo = LOGO    $@
>> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
>> index 01df30a..c9ce3b0 100644
>> --- a/scripts/Makefile.build
>> +++ b/scripts/Makefile.build
>> @@ -316,6 +316,8 @@ quiet_cmd_asn1_compiler = ASN.1   $@
>>  $(obj)/%-asn1.c $(obj)/%-asn1.h: $(src)/%.asn1 $(objtree)/scripts/asn1_compiler
>>       $(call cmd,asn1_compiler)
>>
>> +$(objtree)/scripts/asn1_compiler: $(objtree)/scripts/asn1_compiler.c
>> +
>>  # Build the compiled-in targets
>>  # ---------------------------------------------------------------------------
>>

Likewise, scripts/Makefile has the following file:

hostprogs-$(CONFIG_ASN1)         += asn1_compiler




Please do not screw up Kbuild for Cygwin.

See the answer from Michal (and you agreed)
https://patchwork.kernel.org/patch/7014361/




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux