On 2 September 2015 at 02:26, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> KDEB_SOURCENAME, not SOURCENAME.
Argh, last minute changes in variable names was a bad idea. Fixing up.
>> The source package is useful for GPL compliance, or for feeding to a
>> automated debian package builder.
>>
>> Cc: Chris J Arges <chris.j.arges@xxxxxxxxxxxxx>
>> Cc: maximilian attems <maks@xxxxxxx>
>> Cc: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
>> Signed-off-by: Riku Voipio <riku.voipio@xxxxxxxxxx>
>> ---
>> v4 address Bens commends,
>> - use src_tar function instead of git archive for kernel sources
>> - move KDEB_SOURCENAME setting to Makefile so it can be passed to
>> src_tar
>> - use a toplevel .config file instead of a copy in debian/control
>> - defend against delete of debian/ in clean target
> [...]
>> @@ -391,4 +396,32 @@ EOF
>> > > create_package "$dbg_packagename" "$dbg_dir"
>> fi
>>
>> +if [ "x$1" = "xdeb-pkg" ]
>> +then
>> + cat < debian/rules
>> +#!/usr/bin/make -f
>> +
>> +build:
>> +> > \$(MAKE) sourcename=${sourcename} KDEB_PKGVERSION=${packageversion}
> I don't think this needs to set any variables, though it shouldn't
> hurt.
Ok, I thought that make calls with different parameters might trigger
rebuild, but after some tests this doesn't seem the case. Cleaning up.
>> +binary-arch:
>> + \$(MAKE) sourcename=${sourcename} KDEB_PKGVERSION=${packageversion} bindeb-pkg
> [...]
> Shouldn't this be setting KDEB_SOURCENAME, not sourcename?
Like the variable name in comments, yes. Thanks for patient reviews.
Riku
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
