On 2015-08-25 10:18, Masahiro Yamada wrote: > 2015-08-25 16:47 GMT+09:00 Pavel Fedin <p.fedin@xxxxxxxxxxx>: >> Hello! >> >>> I am not happy with getting weird code to work around issues on >>> non-Linux systems. >> >> What is your criteria of being weird? Why are four #undef's weird ? > > > I am not criticizing your particular patch. > > Once we decide to support building on other OSes, > I fear more and more patches would come in > to fix building issues. While nowadays Linux is often the first OS ported to a new architecture and is cross compiled on another Linux system, I think portable code is a virtue on its own, _unless_ it requires having compatibility wrappers for half of the library calls and whatnot. It's hard to draw a line, but it'd say patches to enable build on Cygwin are OK (since it emulates a POSIX system quite well), whereas patches to enable build on native Windows, dealing with pathname lookup differences, .exe suffixes, adding a libc wrapper, etc, would be frowned upon. Would you agree to such loosely defined criteria? Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
