On Fri, Jul 10, 2015 at 10:25:31AM +0200, Andreas Ruprecht wrote:
> This patchset changes the lexer file to emit a warning if any unhandled
> characters are found in the input. So far, Kconfig options like
>
> +config FOO
> bool
> [...]
>
> (note the wrong '+'!) were parsed without a warning. As simply adding a
> warning for '.' produces lots of warnings as occasionally '---help---'
> is used instead of 'help' (and thus '-' is recognized as an unhandled
> character), we need to handle '---help---' separately.
>
> Changes to v1:
> - add '---help---' in zconf.gperf instead of special casing
> it in zconf.l
>
> Changes to v2:
> - Do no constify char parameter to warn_ignored_character
> - Shorten rule definitions for '.'
>
> Andreas Ruprecht (2):
> kconfig: warn of unhandled characters in Kconfig commands
> kconfig: Regenerate shipped zconf.{hash,lex}.c files
>
> scripts/kconfig/zconf.gperf | 1 +
> scripts/kconfig/zconf.hash.c_shipped | 58 ++++---
> scripts/kconfig/zconf.l | 20 ++-
> scripts/kconfig/zconf.lex.c_shipped | 325 +++++++++++++++++------------------
> 4 files changed, 204 insertions(+), 200 deletions(-)
>
> --
> 1.9.1
>
Looks good to me.
I ran the Kconfiglib test suite on it too. Since it simply compares the
output of Kconfiglib and the C implementation, it doubles as a good
regression test for the C implementation.
Cheers,
Ulf
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
