On Fri, Jul 3, 2015 at 1:11 PM, Stefan Hengelein <stefan.hengelein@xxxxxx> wrote: > 2015-07-03 12:56 GMT+02:00 Stefan Hengelein <stefan.hengelein@xxxxxx>: >> 2015-07-03 12:51 GMT+02:00 Valentin Rothberg <valentinrothberg@xxxxxxxxx>: >>>>> >>>>> The output looks like this: >>>>> scripts/kconfig/conf --allyesconfig Kconfig >>>>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-' >>>>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-' >>>>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-' >>>>> init/Kconfig:222:warning: ignoring unsupported character '-' >>>>> init/Kconfig:222:warning: ignoring unsupported character '-' >>>>> init/Kconfig:222:warning: ignoring unsupported character '-' >>>>> init/Kconfig:244:warning: ignoring unsupported character '-' >>>>> init/Kconfig:244:warning: ignoring unsupported character '-' >>>>> init/Kconfig:244:warning: ignoring unsupported character '-' >>>>> [...] >>>>> >>>>> So we would need to add special treatment for '-' also in the command >>>>> case, right? But that doesn't look appealing to me, more like a dirty, >>>>> dirty hack around the actual problem... >>>>> >>>>> Regards, >>>>> >>>>> Andreas >>>>> >>>> >>>> Except for scattered accidents like in the original message, which are >>>> hopefully pretty rare and easy to fix, the only documented thing that depends >>>> on that lexer sloppiness is the ---help--- "token". >>>> >>>> I'd just add "---help---" as another T_HELP alias (or get rid of it altogether, >>>> but that's probably more work than it's worth). Tightening things up should be >>>> safe after that. >>> >>> This idea has a big ACK from me. It seems to me the cleanest way to >>> solve the issue. >>> >> >> Agreed! I also wanted to suggest this solution, but Ulf was faster :) >> >> Kind Regards, >> Stefan > > However, thinking about this solution a little more.... > This change might lead to parser conflicts....shift-reduce conflicts maybe. > > Is the '-' used somewhere else and has a distinct token or is it just > ignored and thrown away? > Yeah, I considered that too. Been a few years since I really dug into zconf.{l,y,gperf} and zconf.y, but from a quick look I think it might work out. With things tightened up, '-' should only ever appear as part of identifiers and inside strings and comments. There's no T_MINUS or similar. /Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html