On Mon, Jun 1, 2015 at 12:56 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: > On Fri, 2015-05-29 at 10:16 -0700, Jim Davis wrote: >> On a new Fedora 22 install, running 'make binrpm-pkg' in the v4.1-rc5 >> kernel source tree fails with >> >> rpm --define "_builddir ." --target \ >> x86_64 -bb ./binkernel.spec >> rpm --target: unknown option >> scripts/package/Makefile:60: recipe for target 'binrpm-pkg' failed > > This looks like the issue I ran into a few times after installing > Fedora: the need to install the rpm-build package separately, because it > isn't included in the default install. At least, the installs I do tend > to have it excluded. (The gotcha that I trip over _every_ time is that > rpmbuild is packaged in rpm-build. Note the hyphen.) > >> From that makefile, >> >> # Do we have rpmbuild, otherwise fall back to the older rpm >> RPM := $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \ >> else echo rpm; fi) >> >> but it looks like the rpmbuild functionality has been taken out of >> (plain) rpm now. > > This made me grep rpm's history a bit. I found a change from 2008 that > reads: > Update rpm manpage wrt build modes > - the build modes have been removed ages ago, just point to rpmbuild manual > > And there's a change from 2000 that already reads: > Remove build modes from rpm, use rpmb and/or popt glue instead. Right; the most recent Fedora documentation on rpm I could find (http://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch08s02.html) said the rpm -b passthrough to rpmbuild went away in version 4.1, which was released in 2002. Downloading the 4.1 tarball, and the 4.0.4 tarball before it, and comparing the man pages, it looks like 4.1 was indeed the last version where that trick in the makefile would have worked. > > We could consult people actually familiar with rpm's history, but it > appears plain rpm hasn't been able to build rpms for quite some time. So > I think scripts/package/Makefile should only (try to) use rpmbuild. I'll see if I can knock together a patch in my copious spare time. Jim -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
