[Removed Yann, who has disappeared long ago.] On Sun, 2015-04-12 at 19:44 -0700, Randy Dunlap wrote: > On 04/12/15 14:16, David VomLehn wrote: > > Add support for floating point configuration variables using C syntax. > > Missing justification. > > Missing explanation (or deletion) of > +FILE *log_fp; etc. > > > > --- > > kconfig-frontends/docs/kconfig-language.txt | 2 +- > > kconfig-frontends/frontends/conf/conf.c | 3 +++ > > kconfig-frontends/frontends/gconf/gconf.c | 3 +++ > > kconfig-frontends/frontends/mconf/mconf.c | 4 ++++ > > kconfig-frontends/frontends/nconf/nconf.c | 3 +++ > > kconfig-frontends/frontends/qconf/qconf.cc | 3 +++ > > kconfig-frontends/libs/parser/symbol.c | 24 +++++++++++++++++++++--- > > kconfig-frontends/utils/gettext.c | 3 +++ > > 8 files changed, 41 insertions(+), 4 deletions(-) This was apparently not done on top of the kernel's code. Is this perhaps intended for some out of tree project? Before you consider to resend this as a patch for the kernel, you should know that a proper commit explanation is needed, as Randy already told, before most people even consider actually looking at it. A Signed-off-by tag will also be required, by the way. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
