On Thu, 2015-01-22 at 14:40 +0100, Michal Marek wrote: > On 2015-01-20 17:04, Ben Hutchings wrote: > > On Tue, 2015-01-20 at 00:13 +0100, Arnaud Patard wrote: > >> Ben Hutchings <ben@xxxxxxxxxxxxxxx> writes: > >>> Only arm and arm64 support that target. You should maybe run something > >>> like 'make -n dtbs_install >/dev/null 2>&1' first to check that the > >>> target is defined. > >> > >> There's a 'set -e' on top of the script so using make -n will likely > >> result in the script failing, which wouldn't be so nice imho. > > [...] > > > > That's why you use it with the if statement: > > > > # Only some architectures with OF support have this target > > if make -n dtbs_install >/dev/null 2>&1; then > > The problem is that kbuild does not support make -n and some of the > commands are always executed. So the command will silently build the > blobs and just not install them. If the dtbs_install target is defined, they should already have been built at this point. If the target is not defined, why would it do anything? Of course it should be $MAKE not make. > Better do > > if grep -q dtbs_install "arch/$SRCARCH/Makefile"; then > ... > > and hope that there won't be any comment causing a false positive. > Another option is to grep 'make help' output. Ugh. Ben. -- Ben Hutchings I haven't lost my mind; it's backed up on tape somewhere.
Attachment:
signature.asc
Description: This is a digitally signed message part
