Re: [RFC v3] builddeb: Try to determine distribution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sedat Dilek dixit:

>+# Try to determine distribution
>+codename=$(lsb_release --codename --short 2> /dev/null)
>+if [ -n "$KDEB_CHANGELOG_DIST" ]; then
>+        distribution=$KDEB_CHANGELOG_DIST
>+elif [ -n "$codename" ]; then

This is suboptimal: if KDEB_CHANGELOG_DIST is defined,
lsb_release is not necessary. The following snippet
also omits using its output if it fails but still
produces any:

if test -n "$KDEB_CHANGELOG_DIST"; then
	distribution=$KDEB_CHANGELOG_DIST
elif distribution=$(lsb_release -cs 2>/dev/null) && test -n "$distribution"; then
	:
else
	distribution=unstable
	echo "builddeb: Using default distribution of 'unstable' in the changelog"
	echo "builddeb: Set \$KDEB_CHANGELOG_DIST or install lsb-release to change this"
fi

bye,
//mirabilos
-- 
„Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund,
mksh auf jedem System zu installieren.“
	-- XTaran auf der OpenRheinRuhr, ganz begeistert
(EN: “[…]uhr.gz is a reason to install mksh on every system.”)
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux