On 11/26/2014 10:32 PM, Masami Hiramatsu wrote: > (2014/11/12 5:27), Shuah Khan wrote: >> Add a new make target to install to install kernel selftests. >> This new target will build and install selftests. kselftest >> target now depends on kselftest_install and runs the generated >> kselftest script to reduce duplicate work and for common look >> and feel when running tests. >> >> Approach: >> >> make kselftest_target: > > kselftest_install? Thanks for catching this. Will fix it. > >> -- exports kselftest INSTALL_KSFT_PATH >> default $(INSTALL_MOD_PATH)/lib/kselftest/$(KERNELRELEASE) >> -- exports path for ksefltest.sh >> -- runs selftests make install target: > > This direction is OK to me. > > BTW, I've found another path to make selftest in Makefile, > Actually you can do > > make -C tools/ selftest > > And there are selftest_install and selftest_clean targets (but > currently it has a bug and doesn't work, anyway) Thanks for pointing this out. I didn't know this existed. kind of hidden. > > I think we'd better do subdir make instead of adding these targets. > This means that "make kselftest*" should be an alias of "make -C tools/ selftest*" > Yes that would be a good way to go and helps leverage these options at tools/Makefile level. > Also, I'd like to request passing some options like as O=$(objtree) > so that we can make test kmodules in selftests. Sounds good. I will look into it. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
