On 11/11/2014 06:06 PM, Shuah Khan wrote: > On 11/11/2014 02:29 PM, Kees Cook wrote: >> Hi, >> >> Sorry, I still really don't like this approach. While it is all in one >> place (thank you for that), I think it isn't a form that is very >> workable for the people maintaining the self tests. How about this, >> instead of per-Makefile customization, why not define an execution >> framework for these tests instead. > > If I understand correctly, sounds like you don't like the way > install target is implemented in the individual test Makefiles > and the changes I made to run_tests targets to address the code > duplication concern. > > At the moment there is no duplicate code in this patch series > between install and run_tests targets. This is a first step > towards standardizing the framework and a definite improvement > over what we have currently. As I mentioned earlier, my goal > is to make it easier for developers to install and run the > existing tests and evolve the framework as we go. > > Assuming my understanding is correct that: > > -- install and run_tests targets in individual tests can be > refined and automated with a common Makefile approach you > proposed. > -- the rest of the user-interface kselftest_install and kselftest > are good. > > I would like to propose that we get started with the current > implementation and refine it based on the following ideas you > suggested. The refinements you are recommending are confined > to selftests and can be made after the kselftest_install > gets added. Adding kselftest_install makes it easier to make > the refinements as it defines overall UI. > Hi Kees, Are you ok with the above proposal? I understand this approach might not be perfect, however it is a step in the right direction to enable and make it easier to run them. I would like to get some initial work in for 3.19 if at all possible. I plan to evolve the back-end to make it easier to write and maintain for developers writing tests going forward. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
