>>> On 05.11.14 at 11:36, <pebolle@xxxxxxxxxx> wrote:
> On Tue, 2014-11-04 at 14:14 +0000, Jan Beulich wrote:
>> I think it should stay, even if my flex version may be slightly different
>> from the one that was used originally. As above - it's simply a result
>> of re-generating.
>
> (This annoyed me enough to dive a bit deeper. This message is mainly to
> archive my notes publicly.)
>
> This #define was added in v3.1. See commit 2f76b358f9fb ("kconfig: regen
> parser"). Commit explanations were probably a bit expensive then since
> this is all the info we have: we don't know why this was done, nor how
> (which program, which options, etc.).
>
> Anyhow, I don't think ECHO is used anywhere. grepping for ECHO in
> scripts/ finds dtc-lexer.lex.c_shipped, lex.lex.c_shipped, and this
> file. In the other two _shipped files ECHO is actually used. So,
> apparently it's not a bit of lex magic. The #define might as well be
> removed.
Again - this is code that gets generated by flex, and hence
dropping it (entirely, or the hunk that changes it) will make the
discussion re-appear the next time someone re-generates the
file.
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
