On Tue, 2014-11-04 at 11:35 +0100, Peter Kümmel wrote:
Again, this patch, though smaller that the previous, is not obviously
trivial. So, could you please add a few lines describing current
behavior, why it's wrong, and how this patch fixes it? That might
increase the chance this patch gets some review.
> Signed-off-by: Peter Kümmel <syntheticpp@xxxxxxx>
> ---
> scripts/kconfig/qconf.cc | 7 +++++++
> scripts/kconfig/qconf.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index 9d3b04b..014df76c 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -1198,6 +1198,7 @@ ConfigSearchWindow::ConfigSearchWindow(ConfigMainWindow* parent, const char *nam
> layout2->addWidget(editField);
> searchButton = new QPushButton(_("Search"), this);
> searchButton->setAutoDefault(FALSE);
> + searchButton->setFocusPolicy(Qt::NoFocus);
> connect(searchButton, SIGNAL(clicked()), SLOT(search()));
> layout2->addWidget(searchButton);
> layout1->addLayout(layout2);
> @@ -1235,6 +1236,11 @@ ConfigSearchWindow::ConfigSearchWindow(ConfigMainWindow* parent, const char *nam
> }
> }
>
> +void ConfigSearchWindow::setFocusOnLineEdit()
> +{
> + editField->setFocus(Qt::OtherFocusReason);
> +}
> +
> void ConfigSearchWindow::saveSettings(void)
> {
> if (name()) {
> @@ -1506,6 +1512,7 @@ void ConfigMainWindow::searchConfig(void)
> if (!searchWindow)
> searchWindow = new ConfigSearchWindow(this, "search");
> searchWindow->show();
> + searchWindow->setFocusOnLineEdit();
> }
>
> void ConfigMainWindow::changeMenu(struct menu *menu)
> diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
> index bde0c6b..6f2c4d6 100644
> --- a/scripts/kconfig/qconf.h
> +++ b/scripts/kconfig/qconf.h
> @@ -288,6 +288,7 @@ public:
> public slots:
> void saveSettings(void);
> void search(void);
> + void setFocusOnLineEdit(void);
>
> protected:
> QLineEdit* editField;
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
