On 2014-10-23 03:11, Steven Rostedt wrote: > On Wed, 22 Oct 2014 21:44:08 +0200 > Michal Marek <mmarek@xxxxxxx> wrote: > >> Dne 22.10.2014 v 16:19 Steven Rostedt napsal(a): >>> >>> Commit 7ff525712acf "kbuild: fake the "Entering directory ..." message >>> more simply" changed the output of "make kernelrelease" such that the >>> kernel release version was not the last line printed. This broke various >>> tools that would find the kernel release with "make kernelrelease | tail -1". >> >> The cleaner and recommended (see recent make help) way is to use make -s: >> >> $ make O=build -s kernelrelease >> 3.18.0-rc1+ >> >> no further processing is needed. > > > I don't mind changing my script with your patch. But this does break > other scripts of mine that I need to hunt down and change. My fear is > why do we need the '-s' when there may be other methods to preserve the > old functionality. If you have scripts that only do x=$(make kernelrelease), then you should definitely fix them. You are right that the make kernelrelease | tail -1 trick had always been working until 7ff525712acf, so I can apply your patch. But please fix ktest.pl so that it's consistent with what the help text says. Also, the Makefile patch should cover kernelversion and image_name as well. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
