On 11/08/14 19:41, Silvio Fricke wrote: > Hi Justin, > > > 2014-08-11 19:23 GMT+02:00 justin <jlec@xxxxxxxxxx>: >> >> On 11/08/14 16:22, Silvio Fricke wrote: >>> please review this patch. >>> I'm a little bit unsure if this patch is technicaly state-of-the-art because >>> kbuild does it right. The problem is that some cross-toolchains (on my box is >>> yocto installed) change the pkg-config search pathes to do some package-config >>> setups for cross compiling. >>> But the init of the toolchain manipulates PKG_CONFIG_SYSROOT_DIR and >>> PKG_CONFIG_PATH variables that a pkg-config call searches in the wrong place to >>> find the package and gives back the wrong values which we use to test the >>> availability of ncurses installation and this break the [x,g,menu]config. >>> >>> Some recommendations for this? >> >> What would happen in a real crosscompile case? > > > In a real crosscompile case we don't have a "crosscompile" [x,g,menu]config. > This step is ever made with the host-toolchain. Or I miss something here? > You are right, no need for using crosscompile to configure the kernel. Looks good to me. Justin
Attachment:
signature.asc
Description: OpenPGP digital signature
