On Fri, Jul 18, 2014 at 10:34:37PM -0300, Vinícius Tinti wrote: > Allows kbuild to generate LLVM bitcode files with the .ll extension when > building with Clang. > > # c code > CC=clang make kernel/pid.ll > > # asm code > CC=clang make arch/arm/kernel/calls.ll > > Signed-off-by: Vinícius Tinti <viniciustinti@xxxxxxxxx> > Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx> > --- > Makefile | 7 +++++++ > scripts/Makefile.build | 18 ++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/Makefile b/Makefile > index f3c543d..4eb0d14 100644 > --- a/Makefile > +++ b/Makefile > @@ -1484,6 +1484,13 @@ endif > %.symtypes: %.c prepare scripts FORCE > $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > > +ifeq ($(COMPILER),clang) > +%.ll: %.c prepare scripts FORCE > + $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > +%.ll: %.S prepare scripts FORCE > + $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@) > +endif Can we drop the test for $(COMPILER) here? If one try this with gcc then gcc will just fail if it do not support the clang flags supplied. And help section should be updated to list .ll too. > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index bf3e677..9ea19d6 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -174,6 +174,14 @@ cmd_cc_symtypes_c = \ > $(obj)/%.symtypes : $(src)/%.c FORCE > $(call cmd,cc_symtypes_c) > > +ifeq ($(COMPILER),clang) > +quiet_cmd_cc_ll_c = CC $(quiet_modtag) $@ > +cmd_cc_ll_c = $(CC) $(c_flags) $(DISABLE_LTO) -fverbose-asm -emit-llvm -S -o $@ $< Can we drop the test for COMPILER here too? Do -fverbose-asm make sense when generating .ll files? It looks like a leftover from what you copied. > +# LLVM bitcode > +# --------------------------------------------------------------------------- > +ifeq ($(COMPILER),clang) > +quiet_cmd_as_ll_S = CPP $(quiet_modtag) $@ > +cmd_as_ll_S = $(CPP) $(a_flags) -o $@ $< > + > +$(obj)/%.ll: $(src)/%.S FORCE > + $(call if_changed_dep,as_ll_S) > +endif This chunk belongs together with the other chunk. There is no reason to separate .S => .ll and .c => .ll rules. The current rules for .c => .lst etc is a mess and not something to be too much inspired from. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
