Hello, (adding Yann and linux-kbuild to recipents) On Wed, Jul 02, 2014 at 11:35:12AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 02, 2014 at 11:57:23AM +0200, Uwe Kleine-König wrote: > > This fixes the following warning: > > > > warning: (ARCH_MULTIPLATFORM && ARCH_INTEGRATOR && ARCH_SHMOBILE_LEGACY) selects ARM_PATCH_PHYS_VIRT which has unmet direct dependencies (!XIP_KERNEL && MMU && (!ARCH_REALVIEW || !SPARSEMEM)) > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > I'm not sure why ARCH_MULTIPLATFORM appears here. It depends on MMU, > > isn't selectable at the same time as ARCH_REALVIEW and XIP_KERNEL > > depends on !ARCH_MULTIPLATFORM. > > The message is extremely confusing. It would read better if those > && were || - because ARM_PATCH_PHYS_VIRT is selected by > ARCH_MULTIPLATFORM _or_ ARCH_INTEGRATOR _or_ ARCH_SHMOBILE_LEGACY: right, so there are two things that could be improved here. The resolution I'd prefer is to make this two warnings: ARCH_INTEGRATOR selects ARM_PATCH_PHYS_VIRT which has unmet direct dependencies (!XIP_KERNEL && MMU) ARCH_SHMOBILE_LEGACY selects ARM_PATCH_PHYS_VIRT which has unmet direct dependencies (!XIP_KERNEL && MMU) ARCH_REALVIEW cannot be selected at the same time as ARCH_INTEGRATOR or ARCH_SHMOBILE_LEGACY, so that can be dropped. And as stated above ARCH_MULTIPLATFORM isn't an issue. This doesn't have the natural language problem that ARCH_MULTIPLATFORM *and* ARCH_INTEGRATOR *and* ARCH_SHMOBILE_LEGACY all select ARM_PATCH_PHYS_VIRT. > config ARCH_MULTIPLATFORM > select ARM_PATCH_PHYS_VIRT > > config ARCH_INTEGRATOR > select ARM_PATCH_PHYS_VIRT > > config ARCH_SHMOBILE_LEGACY > select ARM_PATCH_PHYS_VIRT > (For reference, the patch did: - select ARM_PATCH_PHYS_VIRT + select ARM_PATCH_PHYS_VIRT if MMU for ARCH_INTEGRATOR and ARCH_SHMOBILE_LEGACY) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
