Hi Michal, On Tue, 10 Jun 2014 14:22:00 +0200 Michal Marek <mmarek@xxxxxxx> wrote: > On 2014-06-10 14:02, Masahiro Yamada wrote: > > Hi Michal, > > > > On Tue, 10 Jun 2014 13:36:48 +0200 > > Michal Marek <mmarek@xxxxxxx> wrote: > > > >> On 2014-06-10 13:17, Masahiro Yamada wrote: > >>> IMHO: > >>> If all shell scripts invoked by $KBUILD_SHELL should be sh-compatible, > >>> "KBUILD_SHELL" should always be set to "/bin/sh" and > >>> users should not change it. > >>> > >>> I still don't understand why bash is preferable for KBUILD_SHELL. > >> > >> I'm just speculating, but the reason might have been that if you are > >> compiling Linux on some oddball UNIX system, the POSIX shell might not > >> be "/bin/sh", but some other path, who knows which. But if $BASH is > >> defined or if there is /bin/bash, then it's very likely the familiar GNU > >> Bash. Hence the preference. Of course, the side effect is that it makes > >> it easy to introduce bash-only constructs into the scripts :-/. > > > > Hmm, > > We set the default value to /bin/sh (KBUILD_SHELL ?= /bin/sh) > > but allowing oddball system users to override it like, > > export KBUILD_SHELL=/bin/bash; make > > > > Does this sounds reasonable? > > I'm not against it in principle, but it will have to wait for the next > merge window, so that it sees more testing in linux-next. I'd like to > push the current set of changes to Linus and time is getting tight. > Right. We do not need to rush to apply this patch now. Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
