Re: [PATCH v2 1/1] builddeb: add arm64 in the supported architectures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9 June 2014 03:15, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> On Sun, 2014-04-13 at 14:26 +0100, Ben Hutchings wrote:
>> On Sat, 2014-04-12 at 15:53 +0300, Fathi Boudra wrote:
>> > Signed-off-by: Fathi Boudra <fathi.boudra@xxxxxxxxxx>
>>
>> Reviewed-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
>>
>> > ---
>> >  scripts/package/builddeb | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
>> > index f46e4dd..0bf29a6 100644
>> > --- a/scripts/package/builddeb
>> > +++ b/scripts/package/builddeb
>> > @@ -42,6 +42,8 @@ create_package() {
>> >             debarch=hppa ;;
>> >     mips*)
>> >             debarch=mips$(grep -q CPU_LITTLE_ENDIAN=y $KCONFIG_CONFIG && echo el || true) ;;
>> > +   arm64)
>
> Now I'm not so sure.  As we are comparing with the 'machine' name
> ($UTS_MACHINE, not $ARCH or $SRCARCH), shouldn't this actually check for
> aarch64?

not sure. I've seen Ian comment (added to the cc list). He's proposing:

[...]
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -28,7 +28,7 @@ create_package() {
        # Attempt to find the correct Debian architecture
        local forcearch="" debarch=""
        case "$UTS_MACHINE" in
-       i386|ia64|alpha)
+       i386|ia64|alpha|arm64)
                debarch="$UTS_MACHINE" ;;
        x86_64)
                debarch=amd64 ;;
[...]

I'm taking a closer look now.

> Ben.
>
>> > +           debarch=arm64 ;;
>> >     arm*)
>> >             debarch=arm$(grep -q CONFIG_AEABI=y $KCONFIG_CONFIG && echo el || true) ;;
>> >     *)
>>
>
> --
> Ben Hutchings
> One of the nice things about standards is that there are so many of them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux