Re: [PATCH 0/5] kbuild: Clean-up and bug fixes of scripts/Makefile.host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,


On Fri, 6 Jun 2014 15:25:54 +0200
Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> On Fri, Jun 06, 2014 at 10:30:58AM +0900, Masahiro Yamada wrote:
> > 
> > Masahiro Yamada (5):
> >   kbuild: fix a typo in scripts/Makefile.host
> >   kbuild: fix a bug of C++ host program handling
> >   kbuild: clean up scripts/Makefile.host
> >   kbuild: clean-up and bug fix of scripts/Makefile.host
> >   kbuild: create directory of .o files from shlib-objs notation
> 
> All bug-fixes looks good.
> But rahter than fixing this please consider if
> we can drop the features.

OK.
I dropped shared object feature and posted v2.

> The shlib stuff is for example no longer used and should be deleted.
> Do we have any host progrs where we need to create directories as
> is fixed in these patches?
> If not then rip it out too.

I hesitate to remove directory creation feature because:

[1] Kbuild is already used in some other projects. 
     Makefile.build, Makefile.lib, Makefile.host etc.
    are really useful build scripts.
    So, I think they should be kept generic enough
    for the maximum code re-use  in other projects.
    It is true that we no longer have hostprogs in Kernel where
    we need to create directories.
    But there might  be necessity in other projects.
    (At least, U-boot's hostprogs-y is depending on this feature.)
[2] For consistency.
     obj-y supports automatic directory creation.
     It is symmetrical that we support it for hostprogs-y.

In v2,  I simplified Makefile.host much more,
so please let me keep it.


Best Regards
Masahiro Yamada

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux