Re: [PATCH] builddeb: fix missing headers in linux-headers package on arm architecture

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-04-14 at 15:19 +0300, Fathi Boudra wrote:
> The kernel headers package (linux-headers) doesn't include
> the arch/arm/mach-*/include header files.
> 
> It makes the package unusable on ARM architecture and prevent
> out-of-tree modules build:
>  /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
>  fatal error: mach/memory.h: No such file or directory
>  #include <mach/memory.h>
>  ^
>  compilation terminated.
> 
> While this patch explicitely test arm architecture, avr32 and blackfin are
> affected since they ship mach-* headers. However, they haven't been included
> in the test because they aren't official architectures supported by Debian.

I don't see why you can't generically look for all include directories
in arch/$SRCARCH.  There also seem to be some files missing for several
other architectures:

arch/ia64/module.lds
arch/m68k/kernel/module.lds
arch/mips/Kbuild.platforms
arch/mips/*/Platform

In the Debian official packages we use these commands to find
arch-specific headers and scripts:

	  find arch/$(KERNEL_ARCH) -maxdepth 1 -name 'Makefile*' -print; \
	  find arch/$(KERNEL_ARCH) \( -name 'module.lds' -o -name 'Kbuild.platforms' -o -name 'Platform' \) -print; \
	  find $$(find arch/$(KERNEL_ARCH) \( -name include -o -name scripts \) -type d -print) -print; \

> minor tweak: clean up the linux-headers package by using tar exclude option.
[...]

Shouldn't that be a separate patch?

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux