Re: [PATCH 2/2] kbuild: docbook: specify KERNELDOC dependency correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 20, 2014 at 02:10:11PM +0900, Masahiro Yamada wrote:
> It is not a good idea to describe
> 
>   %.xml: %.tmpl FORCE
>     ...
> 
> and
> 
>   $(BOOKS): $(KERNELDOC)
> 
> separately. This cannot detect missing template files.
> 
> For example, add something to DOCBOOKS variable:
>   DOCBOOKS += foobar.xml
> and run
>   make xmldocs
> 
> It will succeed even if Documention/DocBook/foobar.tmpl
> does not exist.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@xxxxxxxxxxxxxxxx>

Applied to kbuild.git#kbuild, thanks.

Michal

> ---
>  Documentation/DocBook/Makefile | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 237f6dc..824d26a 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -87,13 +87,9 @@ define rule_docproc
>          ) > $(dir $@).$(notdir $@).cmd
>  endef
>  
> -%.xml: %.tmpl FORCE
> +%.xml: %.tmpl $(KERNELDOC) $(DOCPROC) FORCE
>  	$(call if_changed_rule,docproc)
>  
> -###
> -# Changes in kernel-doc force a rebuild of all documentation
> -$(BOOKS): $(KERNELDOC)
> -
>  # Tell kbuild to always build the programs
>  always := $(hostprogs-y)
>  
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux