Andi Kleen <ak@xxxxxxxxxxxxxxx> writes:
> From: Joe Mario <jmario@xxxxxxxxxx>
>
> Here is the workaround I made for having the kernel not reject modules
> built with -flto. The clean solution would be to get the compiler to not
> emit the symbol. Or if it has to emit the symbol, then emit it as
> initialized data but put it into a comdat/linkonce section.
>
> Minor tweaks by AK over Joe's patch.
Patch is fine, but what's with the comment?
> switch (sym[i].st_shndx) {
> case SHN_COMMON:
> + /* Ignore common symbols */
> + if (!strncmp(name, "__gnu_lto", 9))
> + break;
> +
You mean, "/* Ignore symbols from -flto */"?
Other than that, I'm happy for this to go via some other tree:
Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
