Is there any specific reason that this patch is ignored still yet? Compiling the uImage and modules together add the support of samples? Shouldn't it be compiled as a module separately and that is correct behavior in case of if samples are compiled as loadable modules? Thanks, Mohsin Kazmi On Wed, Jul 17, 2013 at 2:15 AM, Jim Baxter <jim_baxter@xxxxxxxxxx> wrote: > > On 16/07/13 20:37, Sam Ravnborg wrote: > > On Tue, Jul 16, 2013 at 07:29:50PM +0100, Jim Baxter wrote: > >> If CONFIG_SAMPLES is enabled with any of the sample > >> modules enabled, they are only built if the make command > >> includes uImage and modules (i.e. make uImage modules). > > > > With the current location samples are built when you build vmlinux. > > And vmlinux is implicit when you just type "make". > > > > With the suggestion you have samples are built when you do "make modules". > > IMO this is less logical than to built them with vmlinux as we do today. > > > > Sam > > > > Hi, > > I am building it with: > make uImage > make modules > > At least bitbake in Yocto and Openembedded is. > > Running make on it's own is the equivalent of: > make vmlinux modules > > which builds the samples directory, however if you run: > make vmlinux > make modules > > Then the Samples are not built, that is what I am trying to fix. > > Thank you, > Jim > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html