Re: [patch 2/2] ./Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 13, 2013 at 02:51:40PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Sergei Trofimovich <slyfox@xxxxxxxxxx>
> Subject: ./Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default
> 
> The common error found in forward-ported/backported patches is missing
> headers.  One recent example (files and function names are mangled):
> 
>     void foo(){}
>     EXPORT_SYMBOL(foo);
> 
> gave only warning
> 
>     foo.c:12345678:5: warning: function declaration isn't a prototype [-Wstrict-prototypes]
>     void foo(){}
>          ^
> 
>     foo.c:12345679:5: warning: data definition has no type or storage class [enabled by default]
>     EXPORT_SYMBOL(foo);
>     foo.c:12345679:5: warning: type defaults to 'int' in declaration of 'EXORT_SYMBOL' [-Werror=implicit-int]
> 
> Now it's a fatal error. Tested on x86_64 allyesconfig.
> 
> [akpm@xxxxxxxxxxxxxxxxxxxx: fix typos in comments]
> Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx>
> Cc: Michal Marek <mmarek@xxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---

Added to kbuild.git#kbuild.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux