On Sun, Sep 15, 2013 at 1:39 AM, Yann E. MORIN <yann.morin.1998@xxxxxxx> wrote: > Sedat, All, > > On 2013-09-14 16:43 +0200, Sedat Dilek spake thusly: >> On Sat, Sep 14, 2013 at 4:21 PM, Clément Chauplannaz <chauplac@xxxxxxxxx> wrote: >> > 2013/9/14 Sedat Dilek <sedat.dilek@xxxxxxxxx>: > [--SNIP--] >> >> So, can you point me/us to the correct commit with subject, please?! >> > >> > My apologies for that mistake. The initial commit, as present in Linus tree, is: >> > 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's >> > POSIX interface >> > >> > Thus, the commit message for this patch should read: >> > scripts/config: fix variable substitution command >> > >> > Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's >> > POSIX interface") accidentally changed the separator between sed `s' command >> > and its parameters from ':' to '/'. >> > >> > Revert this change. >> > >> > Reported-and-tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> > Signed-off-by: Clement Chauplannaz <chauplac@xxxxxxxxx> >> > Signed-off-by: Michal Marek <mmarek@xxxxxxx> >> > >> >> What means "pending" [1]? > > The current script had a latent bug that would trigger when the user want > to set a string that contains a colon ':'. > > This behaviour was changed by Clément, and the bug was then about strings > with a '/' instead. This was a regression for some users. > > The behaviour was then reverted to break on strings containing ':'. > > What is pending is a final fix that will fix both cases. > >> Pending in sense of "we are working on it" or in the sense of >> "exists-but-not-published". > > The final fix is trivial and identified, so I guess that Clément has yet > had time to send the patch. > >> I did not found a hint on the offline linux-kbuild ML. > > That would be Michal's suggestion there: > http://marc.info/?l=linux-kbuild&m=137907001305533&w=2 > I talked with Thorsten (MirBSD and Debian developer) and he suggested: $ sed -e "s^A$before^A$after^A" "$infile" >"$tmpfile" <--- see attached Text-File NOTE: Control character "^A" <--- ASCII 0x01 aka SOH (Start Of Heading) - Sedat - P.S.: Note2myself: vi/vim: Insert-mode: Ctrl-v Ctrl-a >> BTW, the GIT repo of Yann is not browsable (which is sh*t for checking >> commits quickl, I don't want to be forced to checkout). > > Yes, I know about that one. I've already notified the gitorious guys > about the issue, they supposedly fixed it, but it is broken again. > > I will re-open my ticket in a moment. > > Regards, > Yann E. MORIN. > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------'
Attachment:
Text-File
Description: Binary data