On Sun, Aug 04, 2013 at 12:38:28PM +0200, David Graeff wrote: > Split out non-generic Makefile targets into new Makefiles. > Each flavour has its own specific Makefile now. > > Signed-off-by: David Graeff <david.graeff@xxxxxx> > > create mode 100644 scripts/kconfig/gconfig/Makefile > rename scripts/kconfig/{ => gconfig}/gconf.c (99%) > rename scripts/kconfig/{ => gconfig}/gconf.glade (100%) > create mode 100644 scripts/kconfig/lxdialog/Makefile > rename scripts/kconfig/{ => lxdialog}/mconf.c (99%) > create mode 100644 scripts/kconfig/nconfig/Makefile > rename scripts/kconfig/{ => nconfig}/nconf.c (99%) > rename scripts/kconfig/{ => nconfig}/nconf.gui.c (100%) > rename scripts/kconfig/{ => nconfig}/nconf.h (100%) > create mode 100644 scripts/kconfig/qconfig/Makefile > rename scripts/kconfig/{ => qconfig}/qconf.cc (99%) > rename scripts/kconfig/{ => qconfig}/qconf.h (100%) Please provide the full diffstat for the patch. git format-patch -n will do this for you. Each directory should be named after the frontend IMO. So lxdialog dir should be renamed to menuconfig. > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index 844bc9d..08524cc 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -110,6 +100,7 @@ help: > @echo ' nconfig - Update current config utilising a ncurses menu based program' > @echo ' menuconfig - Update current config utilising a menu based program' > @echo ' xconfig - Update current config utilising a QT based front-end' > + @echo ' qconfig - Update current config utilising a QT based front-end' > @echo ' gconfig - Update current config utilising a GTK based front-end' > @echo ' oldconfig - Update current config utilising a provided .config as base' > @echo ' localmodconfig - Update current config disabling modules not loaded' So you sneaked in a new "qconfig" target. This belongs in a separate patch - and we already have xconfig so I suggest to drop it. > -clean-files := qconf.moc .tmp_qtcheck .tmp_gtkcheck > -clean-files += zconf.tab.c zconf.lex.c zconf.hash.c gconf.glade.h > -clean-files += mconf qconf gconf nconf > +clean-files := zconf.tab.c zconf.lex.c zconf.hash.c > clean-files += config.pot linux.pot OK > diff --git a/scripts/kconfig/gconfig/Makefile b/scripts/kconfig/gconfig/Makefile > new file mode 100644 > index 0000000..335ee5e > --- /dev/null > +++ b/scripts/kconfig/gconfig/Makefile > @@ -0,0 +1,63 @@ > +# =========================================================================== > +# Kernel configuration targets > +# These targets are used from top-level makefile > + > +PHONY += gconfig > + > +gconfig: $(obj)/gconf > + $< $(Kconfig) > + > +# =========================================================================== > +# Shared Makefile for some of the kconfig executables: > +# gconf: Used for the gconfig target > +# Based on GTK which needs to be installed to compile it > +# object files used by all kconfig flavours listed above > + > +gconf-objs := gconfig/gconf.o zconf.tab.o > + > +ifeq ($(MAKECMDGOALS),gconfig) > + gconf-target := 1 > +endif > + > +ifeq ($(gconf-target),1) > + hostprogs-y += gconf > +endif > + > +clean-files += zconf.tab.c gconfig/gconf.glade.h gconf zconf.tab.c should be dropped here. Other than these small nits it looks good. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html