On Thu, Aug 08, 2013 at 11:54:49PM +0200, Yann E. MORIN wrote: > Stephen, All, > > On 2013-08-08 21:16 +0200, Yann E. MORIN spake thusly: > > On 2013-08-08 10:36 +1000, Stephen Rothwell spake thusly: > > > On Thu, 8 Aug 2013 10:22:28 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > > wrote: > > > > > > > > More quick testing with an empty file: v3.9 is OK, v3.10 gives > > > > CONFIG_MODULES unset. > > > > Sorry, I don't understand the above. Can you elaborate on what you did, > > what you got, what expected, so I can try to reproduce and fix this, > > please? > > Ok, I've had a look in the linux-next archives, and I think I got it. > Is the following right? > > git clean -d; git clean -dX # To be sure tree is clean > touch empty > make KCONFIG_ALLCONFIG=empty allmodconfig > grep MODULES .config > $ CONFIG_MODULES is not set > > If so, I think I found the reason: the modules symbol is _always_ set to > being valid as soon as KCONFIG_ALLCONFIG is read, even if it was not > present in that file. > > Since it is set to be valid, the following change means it is not > affected another value later on. > > So, I wonder what the best option is: > 1- revert the following, and find another solution, > 2- de-specialise the modules symbol, > 3- or further specialise the modules symbol. If we drop the special handling of "MODULES" and introduced the following in we may fix it - hopefully: config MODULES option modules The option handling is already in place. It is even documented :-) At least we could then drop the sym_lookup here (zconf.y): if (!modules_sym->prop) { struct property *prop; prop = prop_alloc(P_DEFAULT, modules_sym); prop->expr = expr_alloc_symbol(sym_lookup("MODULES", 0)); } Without the sym_lookup I think the symbol will not be defined and tus not marked valid. Soory - no patch as I am busy with day-time job stuff. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html