Jean, All, On Tuesday 16 July 2013 16:33:47 Jean Delvare wrote: > Le Saturday 13 July 2013 à 20:08 +0200, Yann E. MORIN a écrit : > > From: "Yann E. MORIN" <yann.morin.1998@xxxxxxx> > > > > - no need for a double-indirection for the temporary sym_match_arr array > > - the temporary sym_match_arr array is not NULL terminated, so no need > > to allocate n+1 elements > > - two minor style fixes > > - grammar fix in comment > > > > Reported-by: Jean Delvare <jdelvare@xxxxxxx> > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx> > > Cc: Jean Delvare <jdelvare@xxxxxxx> > > --- > > scripts/kconfig/symbol.c | 39 +++++++++++++++------------------------ > > 1 file changed, 15 insertions(+), 24 deletions(-) > > (...) > > You mixed style cleanups with actual code changes, which is usually > avoided. Michal may ask you to split these changes into two separate > patches. Yes, I initially did three patches (style cleanups, n+1 elem, then double-indirection), and I eventually decided to merge them in a single patch. I don't know why I decided that... :-( I'll re-split. > Still, I'm happy with all the changes: > > Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> Thank you! :-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ | | --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no | | http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. | '------------------------------'-------'------------------'--------------------' -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
