On Fri, Jul 12, 2013 at 8:32 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > On Fri, Jul 12, 2013 at 12:16:48AM +0200, Sedat Dilek wrote: >> On Thu, Jul 11, 2013 at 11:12 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: >> > On Thu, Jul 11, 2013 at 11:08 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: >> >> On Thu, Jul 11, 2013 at 11:05:24PM +0200, Sedat Dilek wrote: >> >>> On Thu, Jul 11, 2013 at 11:03 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: >> >>> > On Fri, Jul 05, 2013 at 05:36:21PM +0200, Sedat Dilek wrote: >> >>> >> Hi, >> >>> >> >> >>> >> in which case(s) do you have to set a comma or not? >> >>> > >> >>> > Only when you specify the last option. >> >>> >> >>> You have an example for this? >> >> >> >> Example: >> >> arch/m68k/Makefile:cpuflags-$(CONFIG_M5441x) := $(call cc-option,-mcpu=54455,-mcfv4e) >> >> >> > >> > OK, so if I have multiple cc-options separated vi comma. So a single >> > one it is not mandatory. >> > >> >> So, this can be simplified: >> >> [ arch/x86/realmode/rm/Makefile ] >> >> OLD: >> $(call cc-option, -fno-toplevel-reorder,\ >> $(call cc-option, -fno-unit-at-a-time)) \ > > It works like this: > - Use the option -fno-toplevel-reorder if supported by gcc, > otherwise use the option -fno-unit-at-a-time if supported by gcc. > >> NEW: >> $(call cc-option, -fno-toplevel-reorder, -fno-unit-at-a-time) > It works like this: > - Use the option -fno-toplevel-reorder if supported by gcc, > otherwise use the option -fno-unit-at-a-time. > > So the new variant fails to test if gcc supports -fno-unit-at-a-time before applying > that option. > I do not know with the current minimum gcc version if the checks are required. > But the functionality for the NEW and the OLD variant are not the same. > Great, all your explanation helped me to understand it better. I will give llvmlinux-project a reference to this thread on linux-kbuild ML. - Sedat - > Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
