Dirk, All,
On 2013-05-13 11:23 +0200, Dirk Gouders spake thusly:
> According to the documentation [1], LINES and COLS are initialized by
> initscr(); it does not say anything about the behavior when windows are
> resized.
>
> Do not rely on the current implementation of ncurses that updates
> these variables on resize, but use the propper function calls or macros
> to get window dimensions.
>
> The use of the variables in main() was OK, but for the sake of
> consistency it was modified to use the macro getmaxyx().
>
> [1] ncurses(3X)
>
> Signed-off-by: Dirk Gouders <dirk@xxxxxxxxxxx>
Queued in my tree, with two very, very light changes:
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index dbf31ed..55fe5a6 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
[--SMIP--]
> @@ -1455,14 +1456,19 @@ static void conf_save(void)
>
> void setup_windows(void)
> {
> + int lines;
> + int columns;
I've chamged this to be a single line:
int lines, columns;
[--SNIP--]
> @@ -1470,6 +1476,8 @@ void setup_windows(void)
>
> int main(int ac, char **av)
> {
> + int lines;
> + int columns;
Ditto.
Thank you!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
