On Mon, Apr 08, 2013 at 01:52:35PM +0200, Yann E. MORIN wrote:
> On Sun, Mar 10, 2013 at 05:01:53PM +0100, Yann E. MORIN wrote:
> > Currently, randconfig does randomise choice entries, unless KCONFIG_ALLCONFIG
> > is specified.
[--SNIP--]
> Although this patch does fix the suggested test-case, there are more
> complex situations where this patch is not enough. (I need to shrink down
> the currently failing Kconfig file to the smallest possible test-case).
Here is a newer, worse test-case (with my patch applied ontop Michal's
kbuild/kconfig tree):
---8<--- config.in
config A
bool "A"
if A
choice
bool "B/C"
config B
bool "B"
config C
bool "C"
endchoice
endif # A
if B
choice
bool "D/E"
config D
bool "D"
config E
bool "E"
endchoice
endif # B
---8<---
With an empty './defconfig' file:
KCONFIG_ALLCONFIG=defconfig conf --randconfig config.in
will sometime emit a .config with *both* B=y and C=y although they are
mutually exclusive, being in a choice block.
However, if the two choices are inverted:
---8<--- config.in
config A
bool "A"
if B
choice
bool "D/E"
config D
bool "D"
config E
bool "E"
endchoice
endif # B
if A
choice
bool "B/C"
config B
bool "B"
config C
bool "C"
endchoice
endif # A
---8<---
Then --randconfig will properly randomise *both* choices!
Note: if my patch is not applied, then only B will ever be selected, and
C will never be.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
