Re: Bug#636029: [PATCH] kbuild: Fix missing '\n' for NEW symbols in yes "" | make oldconfig >conf.new

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-02-19 at 02:24 +0200, Regid Ichira wrote:
> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> 
> According to Documentation/kbuild/kconfig.txt, the commands:
> 
>     yes "" | make oldconfig >conf.new
>     grep "(NEW)" conf.new
> 
> should list the new config symbols with their default values.
> However, currently there is no line break after each new symbol.  When
> kconfig is interactive the user will type a new-line at this point,
> but when non-interactive kconfig must print it.
> 
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---

Don't put a '---' here, as the following pseudo-headers should go into
the commit message.

> Reference: http://bugs.debian.org/636029
> Reported-by: 636029-submitter@xxxxxxxxxxxxxxx

Well that's you, isn't it?

> [regid23@xxxxxx: Adjusted Ben's work to apply cleanly to this tree]
> Tested-by: Regid Ichira <regid23@xxxxxx>
[...]

So it should be Reported-and-tested-by: Regid Ichira <regid23@xxxxxx>

Anyway, thanks for moving this forward.

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux