On Sun, Nov 04, 2012 at 03:32:41PM +0800, Adam Lee wrote: > `make rpm-pkg` and `make binrpm-pkg` will write $KERNELRELEASE into rpm > spec files which don't depend on localversion file now. So, the > unchanged spec files will cause failure after localversion file changed. > > I added the localversion file into the dependencies of spec files. > Because that file is not necessary, I made it a empty target, so its > last-modification time will be checked by Make only when it exists. > > Signed-off-by: Adam Lee <adam8157@xxxxxxxxx> > --- > scripts/package/Makefile | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Hi, Michal Any comment about my fix? reproduce steps: 1, make rpm-pkg 2, change localversion 3, make rpm-pkg -- Regards, Adam Lee http://adam8157.info -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html