Re: [PATCH] Add Intel Ivy bridge CPU flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/31/2013 10:45 AM, Alec Bickerton wrote:
on 30/01/13 04:34 H. Peter Anvin gazed into the seeing stone and said...:
On 01/24/2013 09:41 AM, Sam Ravnborg wrote:

--- a/arch/x86/Makefile_32.cpu
+++ b/arch/x86/Makefile_32.cpu
@@ -33,6 +33,7 @@ cflags-$(CONFIG_MCYRIXIII)    += $(call
cc-option,-march=c3,-march=i486) $(align)-f
   cflags-$(CONFIG_MVIAC3_2)    += $(call cc-option,-march=c3-2,-march=i686)
   cflags-$(CONFIG_MVIAC7)        += -march=i686
   cflags-$(CONFIG_MCORE2)        += -march=i686 $(call tune,core2)
+cflags-$(CONFIG_MIVYBRIDGE)        += -march=i686 $(call tune,core-avx-i)
   cflags-$(CONFIG_MATOM)        += $(call cc-option,-march=atom,$(call
cc-option,-march=core2,-march=i686)) \
       $(call cc-option,-mtune=atom,$(call cc-option,-mtune=generic))

Not a fault in your patch - but the x86 guys should learn to use the
X86_ prefix on x86 specific config symbols :-(
For consistency do not add it.


These are some of the oldest config symbols in the entire kernel.

     -hpa


That maybe so, I just want to be able to build an ivy bridge optimised kernel
without having to think about it too much. While I don't know how much it'd
bring, this is more of a convenience than anything else.


I was referring to the lack of the X86_ prefix on the CONFIG_M* symbols.

	-hpa


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux