On 31.1.2013 11:50, James Hogan wrote: > Hi Michal, > > On 31/01/13 10:37, Michal Marek wrote: >> On 31.1.2013 10:41, James Hogan wrote: >>> On architectures which have symbol prefixes, depmod emits lots of false >>> warnings like this: >>> >>> WARNING: $module.ko needs unknown symbol $symbol >>> >>> This is because depmod isn't being passed the -P <symbol_prefix> >>> arguments to specify the symbol prefix to ignore. This option is >>> included since the 3.13 release of module-init-tools. >>> >>> Update scripts/depmod.sh to take extra arguments which are passed >>> through directly to depmod, and update the main Makefile to pass >>> -P $(CONFIG_SYMBOL_PREFIX to scripts/depmod.sh, but only if >>> CONFIG_SYMBOL_PREFIX is set and non-empty. >> >> OK. >> >> >>> scripts/depmod.sh also drops the -P arguments if depmod --version >>> reports module-init-tools with a version number < 3.13. >> >> You can replace the test with a simple >> >> "$DEPMOD" -P _ --help 2>/dev/null >/dev/null > > Thanks for the suggestion. It would be much cleaner, but unfortunately I > tried this on module-init-tools 3.3-pre2 and module-init-tools 3.9 and > both still return success. Indeed, depmod had the modutils fallback, so it did not fail on unknown options immediately. So the version parsing is inevitable. Thanks for checking. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
