Re: [PATCH] fix: spaces in srctree and objtree paths no longer break builds.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 23, 2012 at 08:59:20PM +0530, Sunil Beta Baskar wrote:
> Signed-off-by: Sunil Beta <betasam@xxxxxxxxx>
> ---
>  Makefile |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 07bc925..c2ae267 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -149,8 +149,13 @@ else
>  _all: modules
>  endif
> 
> -srctree        := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
> +srctree            := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR))
>  objtree        := $(CURDIR)
> +
> +# FIX! spaces in path can break build
> +srctree         := $(shell echo $(srctree) | sed "s/ /\\\ /g" )
> +objtree         := $(shell echo $(objtree) | sed "s/ /\\\ /g" )
> +
>  src        := $(srctree)
>  obj        := $(objtree)

I applied your patch manually (the patch is broken).
My build failed like this:
  SYSHDR  arch/x86/syscalls/../include/generated/uapi/asm/unistd_32.h
/bin/sh: /home/sam/kernel/my\ space.git/arch/x86/syscalls/syscallhdr.sh: No such file or directory
make[1]: *** [arch/x86/syscalls/../include/generated/uapi/asm/unistd_32.h] Error 127

This it in other words not enough.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux