Hi Yann, All,
On Sun, Dec 02, 2012 at 06:52:50PM +0100, Yann E. MORIN wrote:
> To make the behavior consistent, may I suggest that you push the
> concept even a bit further:
> - add a "Load" *and* a "Save" buttons
> - get rid of the top-level "Load an Alternate Configuration File"
> and "Save an Alternate Configuration File" entries
>
> For the "Save" and "Load" buttons, please mimick how the nconf frontend
> behaves: prompt for the file to save to/load from, and prefill it with
> the last filename that was entered (".config" per default).
>
> Of course, two patches for that: one for the "Save/Load" buttons, one
> to get rid of the top-level entries afterward.
Thanks, very good suggestion, I will jump in.
> Note: I do not state that your use-case is valid or not. That's your
> call how you configure and test your kernel. However, I think that
> having a consistent behavior across the frontends is a very nice goal
> to pursue.
I understand, I make a mistake in the comment in previous Email.
> See other comments in-lined, below.
>
> > V1-V2: Rewrite the most code to make it more correct
> > V2-V3: Fix the behavior of conf_message_callback when exit.
> > V3-V4:
> > 1: Move Buttons a little left to make them look like symmetrical.
> > 2: Exchange the position between Save button and Exit button.
> > 3: Use conf_save instead of conf_write to make we can save
> > an alternate configuration file with Save button.
> >
> > Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
> > ---
> > scripts/kconfig/lxdialog/menubox.c | 21 +++++++++---------
> > scripts/kconfig/mconf.c | 45 ++++++++++++++++++++++++++++++--------
> > 2 files changed, 47 insertions(+), 19 deletions(-)
> >
> > diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
> > index 1d60473..b445bda 100644
> > --- a/scripts/kconfig/lxdialog/menubox.c
> > +++ b/scripts/kconfig/lxdialog/menubox.c
> > @@ -26,7 +26,7 @@
> > *
> > * *) A bugfix for the Page-Down problem
> > *
> > - * *) Formerly when I used Page Down and Page Up, the cursor would be set
> > + * *) Formerly when I used Page Down and Page Up, the cursor would be set
>
> Space-damage. Don't send trailing-space fixes, or at least add a quick
> note for it at the end of the commit log (eg.: "remove trailing space
> while at it").
Ok, it is right.
Thanks Yann E. MORIN, and All
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
