On Fri, Nov 30, 2012 at 12:39:43PM -0800, H. Peter Anvin wrote: > On 11/29/2012 10:43 AM, Greg Kroah-Hartman wrote: > > > >-/* Used for HOTPLUG */ > >-#define __devinit __section(.devinit.text) __cold notrace > >-#define __devinitdata __section(.devinit.data) > >-#define __devinitconst __constsection(.devinit.rodata) > >-#define __devexit __section(.devexit.text) __exitused __cold notrace > >-#define __devexitdata __section(.devexit.data) > >-#define __devexitconst __constsection(.devexit.rodata) > >+/* Used for HOTPLUG, but that is always enabled now, so just make them noops */ > >+#define __devinit > >+#define __devinitdata > >+#define __devinitconst > >+#define __devexit > >+#define __devexitdata > >+#define __devexitconst > > > > Second question... what about the __exitused __cold notrace annotations? __exitused shouldn't matter, we shouldn't be optimizing these away at all anymore. I don't know about __cold and notrace, but given that these could be traced, I don't see why that marking got there in the first place. In reading compiler-gcc4.h, and knowing just how infrequent these functions are ever called, I would be amazed if the __cold marking ever even helped anything out here. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
