Re: [PATCH 3/3] scripts/kconfig: allow setting the root-menu label from environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yann.

On Thu, Nov 22, 2012 at 01:06:06AM +0100, Yann E. MORIN wrote:
> Currently, the root-menu label is hard-coded in the kconfig frontends
> executables. This means that two projects that use kconfig and want
> to display different root-menu labels can not share the same kconfig
> frontends.
> 
> Instead of hard-coding the label in the frontends, handle it the same
> we handle the CONFIG_ prefix:
>   - get the root-menu label from the environment if present
>   - allow to set it at build time (eg. -DROOTMENU='"Root menu label"')
>   - fallback to a hard-coded default

I have note paid attention to these CONFIG_ patches - and only now
I took a short look at this set and I am not soo hapy
that we start to introduce a lot a environment variables for all this stuff.

(A lot in this context is two).

Could we instead introduce two reserved symbols like this:

config KCONFIG_ROOT_MENU
	string
	default "My own super duper root menu"

config KCONFIG_SYMBOL_PREFIX
	string
	default "SAM_"

the the configuration is included in the kconfig files,
and not something you need to set in the environment.

We already so something remotely like this for SYMBOLS
where one can define:

config MY_SYMBOLS
	option modules

Then MY_SYMBOLS in used as replacement for SYMBOLS

I did not implement this - but it looks sufficiently simple
to warrant getting rid on the dependency on the enviromnet variables.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux