Re: [PATCH] fbdev: make scripts/pnmtologo dependency portable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16.10.2012 03:53, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <yselkowitz@xxxxxxxxxxxxxxxxxxxxx>
> 
> Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
> scripts/pnmtologo to all autogenerated .c files.  An explicit rule
> is required on platforms where the .exe suffix is used for hostprogs.
> 
> Signed-off-by: Yaakov Selkowitz <yselkowitz@xxxxxxxxxxxxxxxxxxxxx>
> ---
> Michal,
> 
> This was originally sent to linux-fbdev, but was forwarded to linux-kbuild
> (but not you) on 12 June.  It has yet to be applied to Linus' tree yet, though.
> 
> Also applies to all 3.x stable branches
> 
>  drivers/video/logo/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
> index 3b43781..3854dbb 100644
> --- a/drivers/video/logo/Makefile
> +++ b/drivers/video/logo/Makefile
> @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
>  extra-y += $(call logo-cfiles,_gray256,pgm)
>  
>  pnmtologo := scripts/pnmtologo
> +$(pnmtologo): $(objtree)/scripts/pnmtologo

Please add an explanation to the changelog how it works.
scripts/pnmtologo is dependent on $(objtree)/scripts/pnmtologo (same
file??), how does it fix the problem that the file is called
scripts/pnmtologo.exe on Cygwin? I do not see any rule for hostprog.exe
-> hostprog in our makefiles.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux