On 2012/07/31 09:57, Borislav Petkov wrote: > On Mon, Jul 30, 2012 at 04:22:12PM -0400, Benjamin Poirier wrote: > > It's against linux-next, which already contains some patches for > > menuconfig. > > Ok, applying against the linux-next from today succeeds. And they seem > to work, I can search for CONFIG_* stuff and then go straight to the > results. > > A couple more observations: > > * The numbering in the search results looks kinda strange and > non-intuitive IMHO. Would it be possible to use the ncurses cursor to > iterate over the search results like one does in the normal menus? I.e., > the horizontal bar which highlights the item with the background color > or whatever - can it be moved up and down with the arrow keys through > the search results too? Further patches are welcome ;) It's not a trivial difference though. The "horizontal bar" is not a curses concept, it's implemented via the menubox lxdialog whereas search results are currently presented via a textbox lxdialog. > > * when searching for "DELAY" for example, I get results without numbers > to which I can't jump to: > > ... > │ Symbol: DEFAULT_IO_DELAY_TYPE [=0] > │ Type : integer > │ > │ > │ Symbol: IO_DELAY_TYPE_0X80 [=0] > │ Type : integer > ... > > maybe because they don't have "---help---" section? Because they don't have a prompt - they don't appear in any menu at all. In that case there's nowhere to jump to. That's why those symbols don't get a number. > > In those cases, you probably want to hide those from the search results? > > Other than that it looks good and I'd say we need more menuconfig > functionality like that which eases/speeds up working with that thing :). > > Thanks. > > -- > Regards/Gruss, > Boris. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
